Crypt/Base: create hmac object outside of while loop

phpseclib · Oct 13, 2018 · 0486356 · 0486356
1 parent f0f7350
commit 0486356
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/phpseclib/Crypt/Base.php b/phpseclib/Crypt/Base.php
@@ -696,10 +696,10 @@ function setPassword($password, $method = 'pbkdf2')
                             include_once 'Crypt/Hash.php';
                         }
                         $i = 1;
+                        $hmac = new Crypt_Hash();
+                        $hmac->setHash($hash);
+                        $hmac->setKey($password);
                         while (strlen($key) < $dkLen) {
-                            $hmac = new Crypt_Hash();
-                            $hmac->setHash($hash);
-                            $hmac->setKey($password);
                             $f = $u = $hmac->hash($salt . pack('N', $i++));
                             for ($j = 2; $j <= $count; ++$j) {
                                 $u = $hmac->hash($u);