Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Blowfish... it's ready...
The code architectur from Crypt_Blowfish() object behavior is equal to the other phpseclib block ciphers.
On benchmark tests on my Linux-Kisterl, Crypt_Blowfish() in MODE_INTERNAL is currently (with a full 448bit key) the fastest block cipher from all in phpseclib.
Even faster than AES-128, and ~50% faster than AES-256.
Strong tested against other Blowfish reference -implementation, works on all php version from 4 to 5.x on any plattform Win/Mac/*nix 32/64bit.
Terra... could you especially check setPassword() ... is the default salt and the $key-length (448bit) ok so?
Usage:
From my side... it's ready to merge.
Greetings :-)