Resource not closed #1510
Closed
Resource not closed #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source was not closed regardless given mode
code formatting
$fp existence check
|
I went ahead and did this here: I opted not to use yours because it wasn't targeting 1.0, among other reasons. I could have squashed and cherry picked but it was just too much effort idk lol. Thanks! |
terrafrost
referenced
this pull request
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
We might have been identified a problem with the SFTP (2.x) version only. This file has been used by League Flysystem SFTP adapter itensively. We found this in the League package itself as well, however the problem could be solved by changing just a few lines of code - see my pull request.
Since we're having a strong dependency on the adapter pattern - provided by the League package - we cannot get rid of it. This has led us to change these lines.
About the problem: We faced with an issue, when transferring files from a local <-> SFTP destination (and vice-versa) and some of the read streams are just being stuck / not closed