Added support for absent parameters field in PSS keys #1583
Conversation
See [here](https://tools.ietf.org/html/rfc4055#section-3.1) for details.
|
Looks good! Just make the update that I mentioned and I'll merge it in! |
|
Oh - also, why do you have Dss in the unit test names? Feels like Pss might be more appropriate? Dss, to me, implies digital signature scheme, aka DSA. |
Sure, this is a typo! |
| @@ -151,8 +151,6 @@ public static function load($key, $password = '') | |||
| $result['MGFHash'] = str_replace('id-', '', $params['maskGenAlgorithm']['parameters']['algorithm']); | |||
| if (isset($params['saltLength'])) { | |||
There was a problem hiding this comment.
We can remove the isset check as well. saltLength is always going to be there, even if the orig key didn't explicitly specify it.
Thanks!
There was a problem hiding this comment.
Nope, because $params is an empty array if there are no parameters.
|
I squashed your commits and cherry-picked them into the 3.0 branch: I then merged that into master. Thanks! |
See [here](https://tools.ietf.org/html/rfc4055#section-3.1) for details.
I just played with CSR creation and had an example created by OpenSSL (as per this simple guide) which ended in
AlgorithmIdentifiers without parameters.This seems to be ok, in view to this: