Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify extension value as critical #1640

Closed
wants to merge 2 commits into from
Closed

Allow to specify extension value as critical #1640

wants to merge 2 commits into from

Conversation

kylekatarnls
Copy link
Contributor

  • DH\PublicKey type hint fix

@terrafrost
Copy link
Member

terrafrost commented Apr 16, 2021 •
edited

Looks good! I (or you) will need to update it to pass the failing unit tests but other than that it looks good! Well and it'll need to be cherry-picked to the 3.0 branch too. No need this needs to be exclusive to the master branch!

kylekatarnls
kylekatarnls commented Apr 16, 2021
View reviewed changes
phpseclib/File/X509.php Outdated Show resolved Hide resolved
@terrafrost
Copy link
Member

This has been merged: 0dabb0c

Thanks!

@terrafrost terrafrost closed this Apr 17, 2021
terrafrost referenced this pull request Apr 17, 2021
@kylekatarnls @terrafrost
Allow to specify extension value as critical
0dabb0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kylekatarnls @terrafrost