timeout in _get_channel_packet during _init_sftp_connection should be a failure #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cherry-picked this to the 1.0 branch and then merged it to 2.0, 3.0 and master: Thanks! |
terrafrost
referenced
this pull request
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using SFTP to connect to a server that timed out during the initial connection, you'll get weird error messages, as the _init_sftp_connection will ignore the timeout and continue to try to connect, but now the underlying SSH connection is in a weird state. Instead, it should treat that as a failure.
The underlying issue can be reproduced by changing the timeout to a really small value (say 1 second) and then connecting to a server far enough away that it'll timeout during connection.