Don't Use Array Unpacking for Status Code -> Error

[chrisguitarguy]

the status_codes property is an array with integer keys and string
values, but the $error value in SFTP::logError was trying to be unpacked
from an array.

Seems to come from cee3f3c, but even at
that commit the status_codes data structure was still an array.

This bug is only present in 3.X, 2.X release didn't unpack here:

phpseclib/phpseclib/Net/SFTP.php

Line 829 in a684f12

$error = $this->status_codes[$status];

[terrafrost]

I cherry-picked your commit to the 3.0 branch and merged it into master:

24150b2

Thanks!

[chrisguitarguy]

@terrafrost cool, thanks! Any idea when this will be in a release?

[terrafrost]

Probably next weekend. I've been attending https://www.longhornphp.com/#/ this weekend! That conference just finished but I got other stuff I still gotta do this weekend too lol

[terrafrost]

I'm actually gonna try to launch the new version in the middle of this coming week or next weekend.

I've been working on adding compression support (zlib and zlib@openssh.com) and I feel like I'm really close. It'd be cool to have it included in the new release but it won't be if I do the release tonight. Still need a few more days to clean that up and get it all tested and all that jazz.

If I don't include it in the upcoming release it could be a few months before a release includes it. Which isn't necessarily a problem lol but I'd just assume have it be included in the next release if at all possible!

[chrisguitarguy]

I'm actually gonna try to launch the new version in the middle of this coming week or next weekend.

Sounds good! Thank you for keeping me updated.

[terrafrost]

A new version has been released.

Thanks for waiting!