Creation of dynamic property is deprecated #1870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not putting a variable exclusively used in another library (mcrypt_compat) into phpseclib core. The fix for this needs to live in mcrypt_compat. |
terrafrost
referenced
this pull request
Dec 7, 2022
|
I added a new method - It'll be that method that I'll call, instead of |
|
New versions of mcrypt_compat have been released that should fix this! I wound up not using continuousBufferEnabled() as that apparently doesn't work on ECB mode so I wound up just using reflection. Had I known I'd be going that route I could have done a release sooner but whatever. It's done now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, with PHP 8.2 I have:
Deprecated functionality: Creation of dynamic property phpseclib3\Crypt\Blowfish::$mcrypt_polyfill_init is deprecated in .../mcryptcompat/mcrypt.php on line 680(with latest mcryptcompat and OpenMage)