Fixed some code style with php-cs-fixer #194
Conversation
|
Per my in-line comment I'm going to close this pull request without merging it. Resubmit it without the public's. That'll make it shorter and easier to review. Everything else I saw looked okay but, for stuff like this... run it against the PEAR CS and post the result. The new pull request should result in less warnings / errors than the current version. eg. less than this: |
I didn't see that comment in your pull request lol. Anyway, I think we should get this in master. And I think the public-keyword should be removed. I don't think it really adds anything anyway except for potential conflicts. All in all, I still think this ought to be closed, but since I closed it last time without reading the comment in your pull request I'll leave it open for the time being... |
|
Yes, all PHP4-compatible changes should be against master. Please send a new PR against master. I am not sure I see the point of replacing var with public. This will likely just cause unnecessary merge conflicts without any benefits. Ideally, use at least one commit per rule you are fixing and also add the rule to the code sniffer ruleset. Maybe the ruleset should be changed to PEAR + ignore first to make this easier. |
|
bantu's pull requests kinda invalidate this one now. |
|
@mpscholten Feel free to take a shot at the stuff that is left. See #197, #198, #199, #200 for how I did it. |
This shouldn't change any logic.
Because of the
public-keyword we cannot put this in the master, but if requested I'll try to get this ready for master too.