[topic/40730] Use strlen() instead of count() in function _equals() of C... #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f Crypt_RSA. It appears that count() always returns int(1) on strings. Thus, this check is pointless as is. strlen() was meant here and is actually required to prevent E_NOTICEs from invalid array accesses using $y[$i].
slowbro
pushed a commit
to slowbro/phpseclib
that referenced
this pull request
Nov 13, 2012
Use exceptions instead of user_error()
phpsyscoder
added a commit
that referenced
this pull request
Feb 26, 2013
Closed
uzulla
added a commit
to uzulla/phpseclib
that referenced
this pull request
Jan 18, 2022
I got some error.
```
Implicit conversion from float 992216.1102294922 to int loses precision
---
#0 [internal function]: {closure}()
phpseclib#1 /some/path/vendor/phpseclib/phpseclib/phpseclib/Net/SSH2.php(3504): stream_select()
phpseclib#2 /some/path/vendor/phpseclib/phpseclib/phpseclib/Net/SSH2.php(3922): phpseclib\Net\SSH2->_get_binary_packet()
phpseclib#3 /some/path/vendor/phpseclib/phpseclib/phpseclib/Net/SFTP.php(537): phpseclib\Net\SSH2->_get_channel_packet()
phpseclib#4 /some/path/vendor/phpseclib/phpseclib/phpseclib/Net/SFTP.php(638): phpseclib\Net\SFTP->_partial_init_sftp_connection()
phpseclib#5 /some/path/vendor/phpseclib/phpseclib/phpseclib/Net/SFTP.php(505): phpseclib\Net\SFTP->_init_sftp_connection()
phpseclib#6 /some/path/vendor/phpseclib/phpseclib/phpseclib/Net/SFTP.php(937): phpseclib\Net\SFTP->_precheck()
phpseclib#7 /some/path/vendor/league/flysystem-sftp/src/SftpAdapter.php(278): phpseclib\Net\SFTP->chdir()
phpseclib#8 /some/path/vendor/league/flysystem-sftp/src/SftpAdapter.php(208): League\Flysystem\Sftp\SftpAdapter->setConnectionRoot()
phpseclib#9 /some/path/vendor/league/flysystem/src/Adapter/AbstractFtpAdapter.php(650): League\Flysystem\Sftp\SftpAdapter->connect()
phpseclib#10 /some/path/vendor/league/flysystem-sftp/src/SftpAdapter.php(453): League\Flysystem\Adapter\AbstractFtpAdapter->getConnection()
phpseclib#11 /some/path/vendor/league/flysystem-sftp/src/SftpAdapter.php(436): League\Flysystem\Sftp\SftpAdapter->upload()
phpseclib#12 /some/path/myApp.php(32): League\Flysystem\Sftp\SftpAdapter->writeStream()
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rypt_RSA.
It appears that count() always returns int(1) on strings. Thus, this check is
pointless as is. strlen() was meant here and is actually required to prevent
E_NOTICEs from invalid array accesses using $y[$i].
As per http://www.frostjedi.com/phpbb/viewtopic.php?f=46&t=40730