X509: always base64-encode extensions for which _getMapping returns a bool #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $spkac = $x509->loadX509($test); | ||
|
|
||
| $this->assertEquals($a['tbsCertificate']['extensions'][8]['extnValue'], 'MDUwDgYIKoZIhvcNAwICAgCAMA4GCCqGSIb3DQMEAgIAgDAHBgUrDgMCBzAKBggqhkiG9w0DBw=='); |
There was a problem hiding this comment.
Swap arguments. $expected comes first.
|
Replaces #628 Btw, I am still curious if it is possible to change the branch a PR is made against. Any ideas? |
Unfortunately it's not. |
bantu
added a commit
to bantu/phpseclib
that referenced
this pull request
Mar 4, 2015
…ensions-2 X509: always base64-encode extensions for which _getMapping returns a bool * terrafrost/x509-unsupported-extensions-2: Tests/X509: fix unit test Tests/X509: add unit test for unsupported extension encoding X509: always base64-encode extensions for which _getMapping returns a bool
|
|
||
| $cert = $x509->loadX509($test); | ||
|
|
||
| $this->assertEquals($cert['tbsCertificate']['extensions'][8]['extnValue'], 'MDUwDgYIKoZIhvcNAwICAgCAMA4GCCqGSIb3DQMEAgIAgDAHBgUrDgMCBzAKBggqhkiG9w0DBw=='); |
There was a problem hiding this comment.
Please swap the parameters. $expected comes first.
|
The latest commit addresses your comment. I'll do the unit test for #627 after this has been merged (rather than creating a second copy of X509Test.php that's pretty much guaranteed to have a merge conflict) |
|
This looks good. The test fails without the patch. :-) |
bantu
added a commit
that referenced
this pull request
Mar 5, 2015
X509: always base64-encode extensions for which _getMapping returns a bool * terrafrost/x509-unsupported-extensions-2: Tests/X509: swap expected and actual value Tests/X509: fix unit test Tests/X509: add unit test for unsupported extension encoding X509: always base64-encode extensions for which _getMapping returns a bool
|
Changed class name on merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same thing as #628 but against 1.0 instead.