Connection reuse refactoring to rid of globals #787
Conversation
dbalabka
force-pushed
the
remove-global-and-earn-25$
branch
3 times, most recently
from
f0ae796
to
afc933e
Compare
dbalabka
force-pushed
the
remove-global-and-earn-25$
branch
from
14f54ec
to
e4cedfe
Compare
|
rebased |
|
I'll try to take a look either this evening or within the next few days as time permits. Thanks! |
|
So overall I think it's a good PR! Email me at terrafrost@php.net your PayPal address and I'll PayPal you the money! |
|
@terrafrost Let's pay after this was merged? |
| */ | ||
| public function getResourceId() | ||
| { | ||
| return '{' . spl_object_hash($this) . '}'; |
There was a problem hiding this comment.
From the line he added in _parse_path...
if (preg_match('/^{[a-z0-9]+}$/i', $host)) {If he doesn't do the curly brackets than localhost would match the regex and it'd try to re-use a non-existant SSH2::$connections['localhost'] connection.
Here's how you'd do it with libssh2:
<?php
$ssh2 = ssh2_connect('domain.tld');
ssh2_auth_password($ssh2, 'user', 'pass');
$sftp = ssh2_sftp($ssh2);
$arr = scandir("ssh2.sftp://$sftp/home/user/public_html");
print_r($arr);If you do echo "ssh2.sftp://$sftp/home/user/public_html" you get ssh2.sftp://Resource id #4/home/user/public_html.
idk I think {} works..
There was a problem hiding this comment.
{} symbols that should not be in URL according to RFC. Same symbols Symfony2 use for place holders in URL routes. So it should safe us from any conflicts, because otherwise regexp will match all alphanumeric domains.
That works! |
dbalabka
force-pushed
the
remove-global-and-earn-25$
branch
from
e4cedfe
to
f690d0e
Compare
|
This fixes #572 ? |
|
@bantu yes. It was completely removed |
|
@terrafrost please invest these money into project. I renounce the prize. Thanks you for your honesty. |
Will do - thanks again for the PR!! |
|
So I think this is good to merge! I can do it but maybe you'd rather do it @bantu ? |
| } | ||
|
|
||
| /** | ||
| * Return existed connection |
|
@terrafrost I'll take care of it as soon as the outstanding comments are addressed. |
dbalabka
force-pushed
the
remove-global-and-earn-25$
branch
from
f690d0e
to
70dd67c
Compare
|
@bantu branch was rebased. Please check fixes according your comments |
|
👍 Thanks a lot |
…-25$ Connection reuse refactoring to rid of globals * torinaki/remove-global-and-earn-25$: Connection reuse refactoring to rid of globals
Refactoring that was discussed in #786