fixed sending stream resulting in a zero byte file #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-cleaned typo
|
I rebased this into one commit and then cherry-picked this into 2.0 and master: Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SFTP
put()with the STDIN file descriptor and the content is piped (and not redirected, see this), fstat (see here) returns a size of 0. Consequently an empty file is created on the remote system, even if the local file descriptor provides a non-empty stream.This PR provides a solution by reading the stream even if size is equal to zero, and letting fread detect the end of file.
Let me know if anything more can be done to get this PR merged
Thanks !