Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom status checks #102

Open
sadortun opened this issue Jun 14, 2014 · 12 comments
Open

Custom status checks #102

sadortun opened this issue Jun 14, 2014 · 12 comments
Labels
Projects

Comments

@sadortun
Copy link
Member

Hi !

Related to issue #99, #92 #2, #96 #74 #35 It would be nice to be able to add custom verification methods. I have dig a little bit in the code, and i think we should add a possiblilty to extend the current checks with custom ones.

I would propose to add folder in which every validation class would be loaded dynamically

/plugins/validations/

I think it would be a great addition to your project.

class AbstractStatusUpdater 
{
    /**
     * Get the human readable name of this updater
     */
    abstract protected function GetLabel();

    /**
     * Check the current server as a service
     * @return double  The latency
     */
    abstract protected function RunCheck();
}

The logic for handling failure and retries ( $run, and $max_run ) would remain in StatusUpdater class and the actual checks would be delegated to the concrete childs classes.

This would allow third parties to create new updaters for specific types of services.

class PingCheck {}
class IMAPCheck {}
class Pop3Check{}
class DNSCheck {}
class MysqlCheck {}

We have some time available to initiate this development in the next weeks, and we would like to make sure to have any available input from your side to ensure the maximum re-usability of this new feature.

Thanks,
Samuel
http://www.sddproductions.com

sadortun added a commit to sadortun/phpservermon that referenced this issue Jun 18, 2014
Implementation is working, more handlers will be added, and clean-up in StatusUpdater class instansiation need to be done

Signed-off-by: Samuel Denis-D'Ortun <sam@sddproductions.com>
@nerdalertdk
Copy link
Contributor

any news on this ?

@sadortun
Copy link
Member Author

@nerdalertdk I have a working branch, but i had some work to do to allow loading forms using ajax depending on which option you choose. You can have a look in my fork : https://github.com/sadortun/phpservermon

@MatejKovacic
Copy link

Hi, any news on this?

I have an OpenVPN server, which is running on 1194 UDP port. Any possibility to monitor it?

@sadortun
Copy link
Member Author

sadortun commented Apr 4, 2016

Hi @MatejKovacic if you are willing to rebase my fork, most of the implementation is there. I am still looking to find spare time to submit a PR

@MatejKovacic
Copy link

Unfortunately, I am not a programmer. OK, I can write some PHP code, but really I am not a programmer.

@Laupe
Copy link
Contributor

Laupe commented May 14, 2016

What is the status of this regulation? Also, would it suited me.

@MatejKovacic
Copy link

ICMP check is working for me: #35 (comment)

However, it would be great if at least this will be implemented in PHPServerMonitor...

@sadortun sadortun modified the milestones: 3.2.x, 3.3 May 21, 2016
@UdoKifferbrehl
Copy link

+1

@mat1010
Copy link

mat1010 commented Feb 7, 2017

+1

@phpfs
Copy link

phpfs commented May 14, 2017

Hi :)

How far did you get with this so far?

Thanks :)

@sadortun
Copy link
Member Author

Almost completed .... since 3 years ! @phpfs if you are willing to compete it I guess there is only a few hours of work to do.

@TimZ99
Copy link
Member

TimZ99 commented Mar 7, 2018

I hope that I have a few hours spare time this month!

@TimZ99 TimZ99 added this to To do in V3.3 Mar 30, 2018
@TimZ99 TimZ99 removed this from the 3.3 milestone Apr 27, 2018
@TimZ99 TimZ99 removed this from To do in V3.3 Apr 27, 2018
@TimZ99 TimZ99 added this to To Do in V3.6 Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
V3.6
  
To Do
Development

No branches or pull requests

8 participants