Added Norwegian language #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimZ99
requested changes
Jul 24, 2018
src/lang/no_NB.lang.php
Outdated
| * along with PHP Server Monitor. If not, see <http://www.gnu.org/licenses/>. | ||
| * | ||
| * @package phpservermon | ||
| * @author Pepijn Over <pep@mailbox.org> |
There was a problem hiding this comment.
Aren't you the author of this file?
src/lang/no_NB.lang.php
Outdated
| 'domain' => 'Domene/IP', | ||
| 'timeout' => 'Timeout', | ||
| 'timeout_description' => 'Antall sekunder å vente på at serveren skal svare.', | ||
| 'authentication_settings' => 'Autentiseringsinnstillinger (Optional)', |
There was a problem hiding this comment.
Does 'optional' have a translation?
src/lang/no_NB.lang.php
Outdated
| 'tab_pushover' => 'Pushover', | ||
| 'tab_telegram' => 'Telegram', | ||
| 'settings_email' => 'E-post innstillinger', | ||
| 'settings_sms' => 'tekstmeldinger innstillinger', |
There was a problem hiding this comment.
tekstmeldinger with a capital letter please
There was a problem hiding this comment.
SMS is used everywhere. Why do you use tekstmeldinger in this case?
src/lang/no_NB.lang.php
Outdated
| 'on_sms' => 'Server \'%LABEL%\' er OPPE igjen: ip=%IP%, port=%PORT%, det var nede i %LAST_OFFLINE_DURATION%', | ||
| 'on_email_subject' => 'VIKTIG: Server \'%LABEL%\' is RUNNING', | ||
| 'on_email_body' => "Server '%LABEL%' er oppe igjen, det var nede i %LAST_OFFLINE_DURATION%:<br/><br/>Server: %LABEL%<br/>IP: %IP%<br/>Port: %PORT%<br/>Dato: %DATE%", | ||
| 'on_pushover_title' => 'Server \'%LABEL%\' is RUNNING', |
src/lang/en_US.lang.php
Outdated
| @@ -306,7 +306,7 @@ | |||
| 'test_message' => 'Test message', | |||
| 'email_sent' => 'Email sent', | |||
| 'email_error' => 'Error in email sending', | |||
| 'sms_sent' => 'SMS sent', | |||
| 'sms_sent' => 'Sms sent', | |||
There was a problem hiding this comment.
SMS is used everywhere else in this file. What is the reason that this one needs to be changed?
|
Fixed the issues :) |
TimZ99
reviewed
Aug 10, 2018
src/lang/no_NB.lang.php
Outdated
| * | ||
| * @package phpservermon | ||
| * @author Daniel S. Billing <daniel@infihex.com> | ||
| * @copyright Copyright (c) 2008-2018 Daniel S. Billing <daniel@infihex.com> |
|
Done 💯 |
dsbilling
changed the title
TimZ99
approved these changes
Aug 13, 2018
|
Thanks a lot! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.