Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named arguments #1334

Open
ciaranmcnulty opened this issue Oct 8, 2020 · 1 comment · Fixed by #1363
Open

Named arguments #1334

ciaranmcnulty opened this issue Oct 8, 2020 · 1 comment · Fixed by #1363
Labels

Comments

@ciaranmcnulty
Copy link
Member

ciaranmcnulty commented Oct 8, 2020

I didn't check yet whether these work with phpspec - specifically the way we intercept wrapped calls using __call, and whether the array keys are passed through sufficiently

We need to check (and add tests) that this sort of thing works

$this->somefunc(foo: 1);
$this->somefunc()->somefunc(bar: 2);

I imagine similar issues with prophecy, including our wrapping

$double->bar(bar:2)->willReturn(true);
$double->foo(foo:1)->shouldBeCalled();

If it's broken then a short-term fix would be to throw an error early.

@ciaranmcnulty
Copy link
Member Author

We need to check constructors etc. This could just be adding to the feature file added in #1363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant