Added verbose option in configuration file #1226
Conversation
|
|
||
| .. code-block:: yaml | ||
|
|
||
| verbose: true |
There was a problem hiding this comment.
I'd like to reserve the option to use the higher verbosity levels for something in future rather than just a boolean
There was a problem hiding this comment.
So you mean that accepted value should be vvv (or 3 that's debug value)? Is not counterintuitive? I mean, if I use vvv or whatever I would expect that also other levels are handled so I would try with v and vv.
WDYT?
There was a problem hiding this comment.
Yeah boolean's probably fine for now then
|
|
||
| namespace Verbose\SpecExample1; | ||
|
|
||
| class ConfigVerbosityConsoleNotSetted |
|
|
||
| """ | ||
| When I run phpspec | ||
| Then Output should contains: |
There was a problem hiding this comment.
The the output should contain: please
|
@ciaranmcnulty I've fix all you asked for in a separate commit, in order to let the review be easier. |
|
@ciaranmcnulty your intuition (from our Slack converstation) was good. Take a look to last commit, it should fix it the right way. |
| @@ -76,6 +78,11 @@ private function setupReRunner() | |||
| $this->application->getContainer()->set('process.rerunner.platformspecific', $this->reRunner); | |||
| } | |||
|
|
|||
| private function resetShellVerbosity() | |||
| { | |||
| putenv(sprintf('SHELL_VERBOSITY=%d', OutputInterface::VERBOSITY_NORMAL)); | |||
There was a problem hiding this comment.
Is there not a way to reset the ApplicationTester instead?
There was a problem hiding this comment.
|
@ciaranmcnulty travis is green 🎉 |
Issue/Feature #1202
Let's discuss it if something is not clear.