Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation notice on dynamic property (PHP 8.2) #1435

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Fix deprecation notice on dynamic property (PHP 8.2) #1435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: ["7.3", "7.4", "8.0", "8.1"]
php: ["7.3", "7.4", "8.0", "8.1", "8.2"]
operating-system: [ ubuntu-latest, macOS-latest, windows-latest ]
composer-flags: [""]
composer-extras: [""]
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
],

"require": {
"php": "^7.3 || 8.0.* || 8.1.*",
"php": "^7.3 || 8.0.* || 8.1.* || 8.2.*",
"phpspec/prophecy": "^1.9",
ciaranmcnulty marked this conversation as resolved.
Show resolved Hide resolved
"phpspec/php-diff": "^1.0.0",
"sebastian/exporter": "^3.0 || ^4.0",
Expand Down
4 changes: 4 additions & 0 deletions features/construction/developer_specifies_object_construction.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,8 @@ Feature: Developer specifies object construction

class ClassConstructor
{
private $type;

public function __construct($type)
{
$this->type = $type;
Expand Down Expand Up @@ -402,6 +404,8 @@ Feature: Developer specifies object construction

class ClassWithFactoryMethod
{
private $type;

private function __construct($type)
{
$this->type = $type;
Expand Down
2 changes: 2 additions & 0 deletions src/PhpSpec/Loader/StreamWrapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ class StreamWrapper

private static $specTransformers = array();

public $context;

public static function register(): void
{
if (\in_array('phpspec', stream_get_wrappers())) {
Expand Down