Skip to content

Commit

Permalink
Allow PHP8 and update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
@ciaranmcnulty
ciaranmcnulty committed Sep 28, 2020
1 parent d66a590 commit 765cd5d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
9 changes: 9 additions & 0 deletions CHANGES.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
1.12.0 / 2020/10/28
===================

* [added] PHP 8 support [@ciaranmcnulty]
* [added] Argument::in() and Argument::notIn() [@viniciusalonso]
* [added] Support for union and mixed types [@ciaranmcnulty]
* [fixed] Issues caused by introduction of named parameters [@ciaranmcnulty]
* [fixed] Issues caused by stricter rounding [@ciaranmcnulty]

1.11.1 / 2020/07/08
===================

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
],

"require": {
"php": "^7.2",
"php": "^7.2 || ~8.0, <8.1",

This comment has been minimized.

Sign in to view

Copy link
@kylekatarnls

kylekatarnls Nov 14, 2020 •
edited
Loading

@ciaranmcnulty The changelog says "PHP 8 support", while the composer.json actually support only PHP 8.0. Is there any particular reason for excluding PHP 8.1+?

This comment has been minimized.

Sign in to view

Copy link
@ciaranmcnulty

ciaranmcnulty Nov 14, 2020

Author Member

It's possible that 8.1 will include things that break prophecy (I think every minor so far in PHP has broken either PhpSpec or Prophecy), probably because we do so much with tokenisation and reflection

There's no harm waiting until there's an RC we can test against

This comment has been minimized.

Sign in to view

Copy link
@kocsismate

kocsismate Dec 6, 2020

I think this is very unfortunate to blindly disable PHP 8.1 support in advance. I wanted to set up a CI build on PHP 8.1 for a project of mine, but I just can't do it (without providing --ignore-platform-reqs to composer install) thanks to this single change. I actually don't mind if new major PHP versions are not declared compatible (~8.0 rather than >7.2), but setting an upper limit to a minor version is too harsh, in my opinion.

This comment has been minimized.

Sign in to view

Copy link
@ciaranmcnulty

ciaranmcnulty Dec 7, 2020

Author Member

We have absolutely no idea what 8.1 will look like yet, so can’t say if prophecy will work

This comment has been minimized.

Sign in to view

Copy link
@fulopattila122

fulopattila122 Apr 17, 2021

It's ok not having an idea and obviously, no one expects proper and full compatibility. But be aware that since you're a dependency of PHPUnit you're preventing the "PHP world" from early testing their libraries against PHP 8.1.

This comment has been minimized.

Sign in to view

Copy link
@ciaranmcnulty

ciaranmcnulty Apr 17, 2021

Author Member

composer has ignore-platform-req=php for exactly this use case

This comment has been minimized.

Sign in to view

Copy link
@fulopattila122

fulopattila122 Apr 17, 2021

composer has ignore-platform-req=php for exactly this use case

yep, using it 😉
"phpdocumentor/reflection-docblock": "^5.2",
"sebastian/comparator": "^3.0 || ^4.0",
"doctrine/instantiator": "^1.2",
Expand Down

0 comments on commit 765cd5d

Please sign in to comment.