Merge pull request #548 from stof/add_return_types

Add return types in comparator classes
phpspec · Dec 8, 2021 · 9765889 · 9765889
2 parents 8aceb6e + 0ccfa8d
commit 9765889
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/Prophecy/Comparator/ClosureComparator.php b/src/Prophecy/Comparator/ClosureComparator.php
@@ -21,13 +21,13 @@
  */
 final class ClosureComparator extends Comparator
 {
-    public function accepts($expected, $actual)
+    public function accepts($expected, $actual): bool
     {
         return is_object($expected) && $expected instanceof \Closure
             && is_object($actual) && $actual instanceof \Closure;
     }
 
-    public function assertEquals($expected, $actual, $delta = 0.0, $canonicalize = false, $ignoreCase = false, array &$processed = array())
+    public function assertEquals($expected, $actual, $delta = 0.0, $canonicalize = false, $ignoreCase = false, array &$processed = array()): void
     {
         if ($expected !== $actual) {
             throw new ComparisonFailure(

diff --git a/src/Prophecy/Comparator/ProphecyComparator.php b/src/Prophecy/Comparator/ProphecyComparator.php
@@ -14,14 +14,17 @@
 use Prophecy\Prophecy\ProphecyInterface;
 use SebastianBergmann\Comparator\ObjectComparator;
 
+/**
+ * @final
+ */
 class ProphecyComparator extends ObjectComparator
 {
-    public function accepts($expected, $actual)
+    public function accepts($expected, $actual): bool
     {
         return is_object($expected) && is_object($actual) && $actual instanceof ProphecyInterface;
     }
 
-    public function assertEquals($expected, $actual, $delta = 0.0, $canonicalize = false, $ignoreCase = false, array &$processed = array())
+    public function assertEquals($expected, $actual, $delta = 0.0, $canonicalize = false, $ignoreCase = false, array &$processed = array()): void
     {
         parent::assertEquals($expected, $actual->reveal(), $delta, $canonicalize, $ignoreCase, $processed);
     }