Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[symfony 3.1.x compatibility] Use phpdocumentor/reflection-docblock 3.0 #272

Closed
karser opened this issue May 16, 2016 · 15 comments
Closed

Comments

@karser
Copy link

karser commented May 16, 2016

Hello, I encountered with a conflict that will eventually prevent users to update to Symfony 3.1
composer output:

phpunit/phpunit 5.* requires phpspec/prophecy, 
phpspec/prophecy requires phpdocumentor/reflection-docblock ~2.0
​phpdocumentor/reflection-docblock ~2.0  conflicts with symfony 3.1*​

phpdocumentor/reflection-docblock already has 3.0 stable version phpDocumentor/ReflectionDocBlock#70

Please see conflict section https://packagist.org/packages/symfony/symfony#3.1.x-dev

@aik099
Copy link
Member

aik099 commented May 16, 2016

Thanks for noticing. Would you please send a PR that would allow usage of 2.0 or 3.0 version of ​phpdocumentor/reflection-docblock?

@GrahamCampbell
Copy link
Contributor

that would allow usage of 2.0 or 3.0 version of ​phpdocumentor/reflection-docblock?

👍

@tacman
Copy link

tacman commented May 26, 2016

Symfony 3.1RC1 was released today. Any progress on this conflict?

@theofidry
Copy link
Contributor

See #264 and #273. There's some work started there but that could not be finished due to lack of time.

@hiddewie
Copy link

Symfony 3.1 was just released. Is there any progress here, because this issue prevents an upgrade of Symfony when using PHPUnit?

@dunglas
Copy link
Contributor

dunglas commented May 30, 2016

See #275

@luispabon
Copy link

Will the aforementioned fix make it to 3.1.1?

@stof
Copy link
Member

stof commented May 31, 2016

@luispabon which 3.1 version are you talking about ?

@dunglas
Copy link
Contributor

dunglas commented May 31, 2016

@luispabon this isn't a problem in Symfony. It's a problem in Prophecy (because of a bug in reflection-docblock). See #275.

@theofidry
Copy link
Contributor

@luispabon as the problem doesn't come from Symfony, Symfony doesn't need a new release, only reflection-docblock does :)

@stof
Copy link
Member

stof commented May 31, 2016

@theofidry and Prophecy as well, with the support of reflection-docblock 3.x being merged

@theofidry
Copy link
Contributor

true

@ozahorulia
Copy link

@stof any news here?

@theofidry
Copy link
Contributor

From #275 (comment):

I will do a release this evening

@stof
Copy link
Member

stof commented Jun 7, 2016

1.6.1 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants