Allow Symfony 2.8 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soullivaneuh
force-pushed
the
symfony-2.8
branch
4 times, most recently
from
1485439
to
0dddc14
Compare
|
https://travis-ci.org/Algatux/influxdb-bundle/jobs/134418403#L171 Seems some of your dependencies are not compatible with Symfony 3.1. Shall I remove this part? Related issue: phpspec/prophecy#272 |
|
Hi thanks a lot for your pr. I will take a look as soon as possible. Yes please remove symfony 3.1 for now. |
As a library, dependencies tests should not be locked at all.
Symfony 2.8 IS the same as 3.0, but with the deprecated old feature. This was done to provide an easy upgrading way between 2.x and 3.x. Lot of people are still on 2.x version of Symfony. Nothing has to be changed on the project codebase. Plus, this is a LTS version. It's important to keep support on it. Ref: http://symfony.com/blog/transition-from-symfony-2-7-to-3-0-symfony-2-8-on-its-way
The goal is to test the library against multiple versions of Symfony and with lowest dependencies.
|
@Algatux done! 👍 |
|
Thanks you for the merge! 👍 Could you please tag a new release for that? |
|
Those beautiful, verified commits… squashed… |
|
@soullivaneuh @greg0ire sorry for the squash guys! I was verry excited for the PR 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 2.8 IS the same as 3.0, but with the deprecated old feature.
This was done to provide an easy upgrading way between 2.x and 3.x.
Lot of people are still on 2.x version of Symfony.
Nothing has to be changed on the project codebase.
Plus, this is a LTS version. It's important to keep support on it.
Ref: http://symfony.com/blog/transition-from-symfony-2-7-to-3-0-symfony-2-8-on-its-way
Note I also removed the
composer.lockfile and replacedcomposer installbycomposer update.As a library, dependencies tests should not be locked at all.
Travis was update to test multiple Symfony versions so you will have the proof that your bundle is compatible. 👍