Allow MethodProphecy::willThrow() to accept Throwable as string
#429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add additional check for existence of interface in contructor - change `is_subclass_of` to `is_a` to allow for `Throwable` and subclasses of `Throwable` - add specs for cases of `Throwable` and extensions of `Throwable` To maintain support for php 5.3 the new specs are only applicable for PHP 7.0 and higher and `ThrowPromise::isValidThrowable()` checks for both `Exception` and `Throwable`. fixes phpspec#428
|
Thanks for the fix! |
drupol
reviewed
Oct 17, 2019
| @@ -84,6 +84,28 @@ function it_throws_an_exception_by_class_name() | |||
|
|
|||
| $this->shouldNotThrow('Prophecy\Exception\InvalidArgumentException')->duringInstantiation(); | |||
| } | |||
|
|
|||
| function it_throws_an_extension_of_throwable_by_class_name() | |||
There was a problem hiding this comment.
Typo: s/extension/exception
There was a problem hiding this comment.
It's been a while since I filed this PR - and it's merged already - but I think I do mean "extension" here. Before you could do willThrow(\Throwable::class), but not with interfaces that extend \Throwable. Hence the usage of \Fixtures\Prophecy\ThrowableInterface; that fixture extends \Throwable. The explanation is in the linked issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_subclass_oftois_ato allow forThrowableand subclasses ofThrowableThrowableand extensions ofThrowableTo maintain support for php 5.3 the new specs are only applicable for PHP 7.0 and higher and
ThrowPromise::isValidThrowable()checks for bothExceptionandThrowable.fixes #428