-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to work with PHPUnit 10 #585
Allow to work with PHPUnit 10 #585
Conversation
Can you rebase your branch to avoid the merge commit ? Also, is this actually a draft PR ? |
71ea1bc
to
8759ac2
Compare
Rebased. I left it as draft since both majors of both packages are not released yet. |
@sebastianbergmann is it safe for us to release this change now or do you expect to do more BC breaks in |
I consider any such changes highly unlikely. |
@sebastianbergmann @stof I've found a BC that's hitting this PR and it's going unnoticed due to the CI here not installing a dev dep: We could easily fix it with the decorator patter, but I don't know if it's to be considered a BC here (since no longer extending the class). |
6c03a2c
to
236677c
Compare
@Jean85 you need to update the specs of that Factory |
@stof I didn't do it because, apart from the fact that I'm not skilled with PHPSpec, I'm not sure on how to proceed:
|
I worked on preparing this work in #589 |
236677c
to
db6fbf5
Compare
Rebased to include #589 |
Closing and reopening to trigger a CI run, now that PHPUnit 10 is released. |
This would require phpspec/phpspec#1443 to test and work completely. |
Let's follow the suggestion from phpspec/phpspec#1443 (comment) and test on an optional CI job requiring master. |
This draft of a PR was needed for me to work on PHPUnit 10 compat on another project, see facile-it/paraunit#172
It allows two packages to the next major version (5), with no other code modifications since there are no BC impacting Prophecy.