add test for deprecation inheritance in trait

phpstan · Mar 17, 2023 · cbbbaa9 · cbbbaa9
1 parent a22b36b
commit cbbbaa9
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 1 deletion.
diff --git a/composer.json b/composer.json
@@ -7,7 +7,7 @@
 	],
 	"require": {
 		"php": "^7.2 || ^8.0",
-		"phpstan/phpstan": "^1.10"
+		"phpstan/phpstan": "^1.10.3"
 	},
 	"require-dev": {
 		"php-parallel-lint/php-parallel-lint": "^1.2",

diff --git a/tests/Rules/Deprecations/CallToDeprecatedMethodRuleTest.php b/tests/Rules/Deprecations/CallToDeprecatedMethodRuleTest.php
@@ -42,6 +42,10 @@ public function testDeprecatedMethodCall(): void
 					"Call to deprecated method deprecatedWithDescription() of class CheckDeprecatedMethodCall\\Foo:\nCall a different method instead.",
 					15,
 				],
+				[
+					"Call to deprecated method prophesize() of class CheckDeprecatedMethodCall\\UsingDeprecatedMethodFromTrait:\nUse TraitReplacingDeprecatedMethod::prophesize()",
+					64,
+				],
 			]
 		);
 	}

diff --git a/tests/Rules/Deprecations/data/call-to-deprecated-method-definition.php b/tests/Rules/Deprecations/data/call-to-deprecated-method-definition.php
@@ -65,3 +65,32 @@ public function deprecatedFoo()
 	}
 
 }
+
+abstract class MethodMovedToTraitClass
+{
+	/** @deprecated Use TraitReplacingDeprecatedMethod::prophesize() */
+	protected function prophesize(): void
+	{
+		echo 'Base';
+	}
+}
+
+trait TraitCallingDeprecatedMethod
+{
+	protected function prophesize(): void
+	{
+		echo 'Trait';
+	}
+}
+
+trait TraitReplacingDeprecatedMethod
+{
+	/**
+	 * @not-deprecated
+	 */
+	protected function prophesize(): void
+	{
+		echo 'Trait';
+	}
+}
+
diff --git a/tests/Rules/Deprecations/data/call-to-deprecated-method.php b/tests/Rules/Deprecations/data/call-to-deprecated-method.php
@@ -53,3 +53,24 @@ public function foo()
 	}
 
 }
+
+
+final class UsingDeprecatedMethodFromTrait extends MethodMovedToTraitClass
+{
+	use TraitCallingDeprecatedMethod;
+
+	public function callProphesize(): void
+	{
+		$this->prophesize();
+	}
+}
+
+final class UsingTraitReplacementForDeprecatedMethod extends MethodMovedToTraitClass
+{
+	use TraitReplacingDeprecatedMethod;
+
+	public function callProphesize(): void
+	{
+		$this->prophesize();
+	}
+}