Add @throws annotation on EntityManagerInterface::flush

phpstan · Nov 8, 2023 · b1e4a69 · b1e4a69
1 parent 90e60ba
commit b1e4a69
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 7 deletions.
diff --git a/stubs/EntityManagerInterface.stub b/stubs/EntityManagerInterface.stub
@@ -60,11 +60,20 @@ interface EntityManagerInterface extends ObjectManager
 	 */
 	public function copy($entity, $deep = false);
 
-  /**
-   * @template T of object
-   * @phpstan-param class-string<T> $className
-   *
-   * @phpstan-return ClassMetadata<T>
-   */
-  public function getClassMetadata($className);
+	/**
+	 * @return void
+	 *
+	 * @throws ORMException
+	 * @throws \Doctrine\DBAL\Exception\UniqueConstraintViolationException
+	 */
+	public function flush();
+
+	/**
+	 * @template T of object
+	 * @phpstan-param class-string<T> $className
+	 *
+	 * @phpstan-return ClassMetadata<T>
+	 */
+	public function getClassMetadata($className);
+
 }
diff --git a/tests/Rules/Exceptions/data/unthrown-exception.php b/tests/Rules/Exceptions/data/unthrown-exception.php
@@ -8,13 +8,21 @@ class FooFacade
 	/** @var \Doctrine\ORM\EntityManager */
 	private $entityManager;
 
+	/** @var \Doctrine\ORM\EntityManagerInterface */
+	private $entityManagerInterface;
+
 	public function doFoo(): void
 	{
 		try {
 			$this->entityManager->flush();
 		} catch (\Doctrine\DBAL\Exception\UniqueConstraintViolationException $e) {
 			// pass
 		}
+		try {
+			$this->entityManagerInterface->flush();
+		} catch (\Doctrine\DBAL\Exception\UniqueConstraintViolationException $e) {
+			// pass
+		}
 	}
 
 }