Improve the type descriptor for SimpleArrayType

[stof]

When converting database values to PHP, this type always produces a list<string>

[stof]

@ondrejmirtes any chance to merge this ? Even though it does not solve all issues related to this SimpleArrayType (due to #436), it improves the situation.

[ondrejmirtes]

This needs a test to understand what kind of error is this preventing. A new method in EntityColumnRuleTest should be fine.

[stof]

@ondrejmirtes I added more tests but they fail. It looks like the @var list<string> is transformed into array<int, mixed> somewhere when checking the EntityColumnRule.

[stof]

And I found the fix for that issue.

[ondrejmirtes]

I disagree with this. If Doctrine can write any array to a property, it's wrong to expect a narrower type.

[stof]

This comment is about explaining the existing logic that you added in e745610

The change I'm doing here is disabling this logic for some cases (when the type descriptor is precise), not enabling it, to avoid reporting errors that are wrong.

I tried to remove this transformation entirely, but this broke some existing tests (the ones added in that commit)

[stof]

Note however that the only type descriptors that return array as type (and so would trigger this logic) are json_array (deprecated in DBAL 2.10 and removed in DBAL 3.0) and array (deprecated in DBAL 3.4+).

So maybe we could drop this logic and return NeverType as done in the JsonType descriptor

[ondrejmirtes]

Oh I get it now, it's nice 👍

I'm not rushing to remove functionality, people use phpstan-doctrine with years-old versions of Doctrine.

[ondrejmirtes]

Please fix the build, otherwise good to go.

[stof]

@ondrejmirtes the build is now green

[ondrejmirtes]

Thank you!

[stof]

@ondrejmirtes do you have any idea when this will be released ?

[ondrejmirtes]

I had to revert some blocking work that wasn't in ideal state, and I can now release this.

[ondrejmirtes]

Hey, I've got some false positives because of this PR, can you please tell me what should be done?

 ------ ----------------------------------------------------------------------------------------------
  Line   app/services/PointOfInterest/PointOfInterest.php
 ------ ----------------------------------------------------------------------------------------------
  109    Property Slevomat\PointOfInterest\PointOfInterest::$seasonMonths type mapping mismatch:
         database can contain list<string> but property expects array<int, float|int|numeric-string>.
  109    Property Slevomat\PointOfInterest\PointOfInterest::$seasonMonths type mapping mismatch:
         property can contain array<int, float|int|string> but database expects array<string>.
 ------ ----------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------------
  Line   app/services/Product/Cancel/ProductCancel.php
 ------ ------------------------------------------------------------------------------------------------
  99     Property Slevomat\Product\Cancel\ProductCancel::$goodsStatuses type mapping mismatch: database
         can contain array<int, string>|null but property expects array<int, int>|null.
  99     Property Slevomat\Product\Cancel\ProductCancel::$goodsStatuses type mapping mismatch: property
         can contain array<int, int>|null but database expects array<string>|null.
 ------ ------------------------------------------------------------------------------------------------

For these properties:

	/** @var array<int, numeric> */
	#[ORM\Column(type: 'simple_array')]
	private array $seasonMonths = [];

	/** @var array<int, int>|null */
	#[ORM\Column(type: 'simple_array')]
	private ?array $goodsStatuses = null;

[stof]

This reports an actual issue. When loaded from the DB, the simple_array does a explode(), so values in the array are strings, not integers. So there is indeed a type mismatch.

See https://github.com/doctrine/dbal/blob/47589fdf56929f1510fd9b394c328c31a7ce13fb/src/Types/SimpleArrayType.php#L53-L62 for the conversion code

[ondrejmirtes]

Thank you!