Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding PHP 7.2 compatibility, it turns out #9 is not enough. Although the existing tests passed, you run into a problem when you actually execute the code of
DoNotExtendNetteObjectRule
orNetteObjectClassReflectionExtension
, because$reflection->isSubclassOf()
triggers the autoloading and it dies on PHP 7.2.This PR solves the problem by:
Nette\Object
.DoNotExtendNetteObjectRule
now checks only the direct parent of a class. But I consider this a bugfix - PHPStan should report problems with project code only, not problems with classes from 3rd party libs that are used and extended in the project.