Fix logic in ShouldCallParentMethodsRule

phpstan · Jul 29, 2020 · 264abf4 · 264abf4
1 parent 20f23c9
commit 264abf4
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/src/Rules/PHPUnit/ShouldCallParentMethodsRule.php b/src/Rules/PHPUnit/ShouldCallParentMethodsRule.php
@@ -21,6 +21,10 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
+		$methodName = $node->getOriginalNode()->name->name;
+		if (!in_array(strtolower($methodName), ['setup', 'teardown'], true)) {
+			return [];
+		}
 		if ($scope->getClassReflection() === null) {
 			return [];
 		}
@@ -34,14 +38,12 @@ public function processNode(Node $node, Scope $scope): array
 		if ($parentClass === false) {
 			return [];
 		}
-
-		if ($parentClass->getName() === TestCase::class) {
+		if (!$parentClass->hasNativeMethod($methodName)) {
 			return [];
 		}
 
-		$methodName = $node->getOriginalNode()->name->name;
-
-		if (!in_array(strtolower($methodName), ['setup', 'teardown'], true)) {
+		$parentMethod = $parentClass->getNativeMethod($methodName);
+		if ($parentMethod->getDeclaringClass()->getName() === TestCase::class) {
 			return [];
 		}
 

diff --git a/tests/Rules/PHPUnit/data/missing-parent-method-calls.php b/tests/Rules/PHPUnit/data/missing-parent-method-calls.php
@@ -75,3 +75,18 @@ public function setUp()
 		return true;
 	}
 }
+
+abstract class BaseTestWithoutSetUp extends TestCase
+{
+
+}
+
+class LoremTest extends BaseTestWithoutSetUp
+{
+
+	protected function setUp(): void
+	{
+		// parent call is not missing here
+	}
+
+}