Ease the usage of AssertRuleHelper::isMethodOrStaticCallOnAssert()

phpstan · Dec 30, 2022 · bf47c49 · bf47c49
1 parent 54a24bd
commit bf47c49
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 15 deletions.
diff --git a/src/Rules/PHPUnit/AssertRuleHelper.php b/src/Rules/PHPUnit/AssertRuleHelper.php
@@ -11,6 +11,9 @@
 class AssertRuleHelper
 {
 
+	/**
+	 * @phpstan-assert-if-true Node\Expr\MethodCall|Node\Expr\StaticCall $node
+	 */
 	public static function isMethodOrStaticCallOnAssert(Node $node, Scope $scope): bool
 	{
 		$testCaseType = new ObjectType('PHPUnit\Framework\Assert');

diff --git a/src/Rules/PHPUnit/AssertSameBooleanExpectedRule.php b/src/Rules/PHPUnit/AssertSameBooleanExpectedRule.php
@@ -4,8 +4,6 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\ConstFetch;
-use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Expr\StaticCall;
 use PhpParser\NodeAbstract;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
@@ -28,9 +26,6 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		/** @var MethodCall|StaticCall $node */
-		$node = $node;
-
 		if (count($node->getArgs()) < 2) {
 			return [];
 		}

diff --git a/src/Rules/PHPUnit/AssertSameNullExpectedRule.php b/src/Rules/PHPUnit/AssertSameNullExpectedRule.php
@@ -4,8 +4,6 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\ConstFetch;
-use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Expr\StaticCall;
 use PhpParser\NodeAbstract;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
@@ -28,9 +26,6 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		/** @var MethodCall|StaticCall $node */
-		$node = $node;
-
 		if (count($node->getArgs()) < 2) {
 			return [];
 		}

diff --git a/src/Rules/PHPUnit/AssertSameWithCountRule.php b/src/Rules/PHPUnit/AssertSameWithCountRule.php
@@ -4,8 +4,6 @@
 
 use Countable;
 use PhpParser\Node;
-use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Expr\StaticCall;
 use PhpParser\NodeAbstract;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
@@ -29,9 +27,6 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		/** @var MethodCall|StaticCall $node */
-		$node = $node;
-
 		if (count($node->getArgs()) < 2) {
 			return [];
 		}