mb_* fatal errors on php8 with invalid encoding

phpstan · Feb 1, 2022 · 0018251 · 0018251
1 parent af38f03
commit 0018251
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/src/Type/Php/MbFunctionsReturnTypeExtension.php b/src/Type/Php/MbFunctionsReturnTypeExtension.php
@@ -4,13 +4,15 @@
 
 use PhpParser\Node\Expr\FuncCall;
 use PHPStan\Analyser\Scope;
+use PHPStan\Php\PhpVersion;
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\BooleanType;
 use PHPStan\Type\Constant\ConstantBooleanType;
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\DynamicFunctionReturnTypeExtension;
+use PHPStan\Type\NeverType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
@@ -44,7 +46,7 @@ class MbFunctionsReturnTypeExtension implements DynamicFunctionReturnTypeExtensi
 		'mb_ord' => 2,
 	];
 
-	public function __construct()
+	public function __construct(private PhpVersion $phpVersion)
 	{
 		$supportedEncodings = [];
 		if (function_exists('mb_list_encodings')) {
@@ -86,9 +88,14 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 		}
 
 		if (count($results) === 1) {
+			$invalidEncodingReturn = new ConstantBooleanType(false);
+			if ($this->phpVersion->getVersionId() >= 80000) {
+				$invalidEncodingReturn = new NeverType();
+			}
+
 			return $results[0]
 				? TypeCombinator::remove($returnType, new ConstantBooleanType(false))
-				: new ConstantBooleanType(false);
+				: $invalidEncodingReturn;
 		}
 
 		return $returnType;

diff --git a/tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php b/tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php
@@ -5314,7 +5314,7 @@ public function dataFunctions(): array
 				'$mbStrlenWithValidEncodingAlias',
 			],
 			[
-				'false',
+				PHP_VERSION_ID < 80000 ? 'false' : '*NEVER*',
 				'$mbStrlenWithInvalidEncoding',
 			],
 			[
@@ -5390,7 +5390,7 @@ public function dataFunctions(): array
 				'$mbEncodingAliasesWithValidEncoding',
 			],
 			[
-				'false',
+				PHP_VERSION_ID < 80000 ? 'false' : '*NEVER*',
 				'$mbEncodingAliasesWithInvalidEncoding',
 			],
 			[
@@ -5410,7 +5410,7 @@ public function dataFunctions(): array
 				'$mbChrWithValidEncoding',
 			],
 			[
-				'false',
+				PHP_VERSION_ID < 80000 ? 'false' : '*NEVER*',
 				'$mbChrWithInvalidEncoding',
 			],
 			[
@@ -5430,7 +5430,7 @@ public function dataFunctions(): array
 				'$mbOrdWithValidEncoding',
 			],
 			[
-				'false',
+				PHP_VERSION_ID < 80000 ? 'false' : '*NEVER*',
 				'$mbOrdWithInvalidEncoding',
 			],
 			[