new ReflectionClass() can throw ReflectionException

phpstan · May 2, 2021 · 00d3ef4 · 00d3ef4
1 parent b5e4bf0
commit 00d3ef4
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/src/Reflection/Php/PhpClassReflectionExtension.php b/src/Reflection/Php/PhpClassReflectionExtension.php
@@ -506,6 +506,11 @@ private function createMethod(
 							);
 							$stubPhpDocParameterVariadicity[$name] = $paramTag->isVariadic();
 						}
+
+						$throwsTag = $stubPhpDoc->getThrowsTag();
+						if ($throwsTag !== null) {
+							$throwType = $throwsTag->getType();
+						}
 					}
 				}
 				if ($stubPhpDocPair === null && $reflectionMethod !== null && $reflectionMethod->getDocComment() !== false) {

diff --git a/stubs/ReflectionClass.stub b/stubs/ReflectionClass.stub
@@ -14,6 +14,7 @@ class ReflectionClass
 
 	/**
 	 * @param T|class-string<T> $argument
+	 * @throws ReflectionException
 	 */
 	public function __construct($argument) {}
 

diff --git a/tests/PHPStan/Rules/Exceptions/data/too-wide-throws-method.php b/tests/PHPStan/Rules/Exceptions/data/too-wide-throws-method.php
@@ -90,3 +90,14 @@ public function doFoo(): void
 	}
 
 }
+
+class ThrowsReflectionException
+{
+
+	/** @throws \ReflectionException */
+	public function doFoo(string $s): void
+	{
+		new \ReflectionClass($s);
+	}
+
+}