Add maybe redundant? non zero validation. See https://github.com/phps…

…tan/phpstan-src/blob/55b995235ea6959289189f66893c69344fafb5a2/src/Analyser/MutatingScope.php#L989-L1022
phpstan · May 3, 2022 · 01c2761 · 01c2761
1 parent ef6111f
commit 01c2761
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -2940,11 +2940,18 @@ private function calculateFromScalars(Expr $node, ConstantScalarType $leftType,
 		}
 
 		if ($node instanceof Node\Expr\BinaryOp\Div || $node instanceof Node\Expr\AssignOp\Div) {
+			if ($rightNumberValue === 0 || $rightNumberValue === 0.0) {
+				return new ErrorType();
+			}
 			return $this->getTypeFromValue($leftNumberValue / $rightNumberValue);
 		}
 
 		if ($node instanceof Node\Expr\BinaryOp\Mod || $node instanceof Node\Expr\AssignOp\Mod) {
-			return $this->getTypeFromValue(((int) $leftNumberValue) % ((int) $rightNumberValue));
+			$rightIntegerValue = (int) $rightNumberValue;
+			if ($rightIntegerValue === 0) {
+				return new ErrorType();
+			}
+			return $this->getTypeFromValue(((int) $leftNumberValue) % $rightIntegerValue);
 		}
 
 		if ($node instanceof Expr\BinaryOp\ShiftLeft || $node instanceof Expr\AssignOp\ShiftLeft) {