OverridingMethodRule - RuleErrorBuilder

phpstan · Jun 4, 2020 · 093ae3f · 093ae3f
1 parent 406b5e4
commit 093ae3f
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/Rules/Methods/OverridingMethodRule.php b/src/Rules/Methods/OverridingMethodRule.php
@@ -8,6 +8,7 @@
 use PHPStan\Reflection\MethodPrototypeReflection;
 use PHPStan\Reflection\Php\PhpMethodFromParserNodeReflection;
 use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
 
 /**
  * @implements Rule<InClassMethodNode>
@@ -37,35 +38,35 @@ public function processNode(Node $node, Scope $scope): array
 
 		$messages = [];
 		if ($prototype->isFinal()) {
-			$messages[] = sprintf(
+			$messages[] = RuleErrorBuilder::message(sprintf(
 				'Method %s::%s() overrides final method %s::%s().',
 				$method->getDeclaringClass()->getName(),
 				$method->getName(),
 				$prototype->getDeclaringClass()->getName(),
 				$prototype->getName()
-			);
+			))->nonIgnorable()->build();
 		}
 
 		if ($prototype->isPublic()) {
 			if (!$method->isPublic()) {
-				$messages[] = sprintf(
+				$messages[] = RuleErrorBuilder::message(sprintf(
 					'%s method %s::%s() overriding public method %s::%s() should also be public.',
 					$method->isPrivate() ? 'Private' : 'Protected',
 					$method->getDeclaringClass()->getName(),
 					$method->getName(),
 					$prototype->getDeclaringClass()->getName(),
 					$prototype->getName()
-				);
+				))->nonIgnorable()->build();
 			}
 		} else {
 			if ($method->isPrivate()) {
-				$messages[] = sprintf(
+				$messages[] = RuleErrorBuilder::message(sprintf(
 					'Private method %s::%s() overriding protected method %s::%s() should be protected or public.',
 					$method->getDeclaringClass()->getName(),
 					$method->getName(),
 					$prototype->getDeclaringClass()->getName(),
 					$prototype->getName()
-				);
+				))->nonIgnorable()->build();
 			}
 		}