fix

phpstan · Dec 4, 2023 · 0f7240f · 0f7240f
1 parent 88acd23
commit 0f7240f
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 3 deletions.
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -1426,7 +1426,28 @@ private function resolveType(string $exprString, Expr $node): Type
 		} elseif ($node instanceof Unset_) {
 			return new NullType();
 		} elseif ($node instanceof Expr\PostInc || $node instanceof Expr\PostDec) {
-			return $this->getType($node->var);
+			$varType = $this->getType($node->var);
+
+			$stringType = new StringType();
+			if ($varType->isString()->yes()) {
+				if ($varType->isLiteralString()->yes()) {
+					return new IntersectionType([$stringType, new AccessoryLiteralStringType()]);
+				}
+				if ($varType->isNumericString()->yes()) {
+					return new BenevolentUnionType([
+						new IntegerType(),
+						new FloatType(),
+					]);
+				}
+
+				return new BenevolentUnionType([
+					$stringType,
+					new IntegerType(),
+					new FloatType(),
+				]);
+			}
+
+			return $varType;
 		} elseif ($node instanceof Expr\PreInc || $node instanceof Expr\PreDec) {
 			$varType = $this->getType($node->var);
 			$varScalars = $varType->getConstantScalarValues();
@@ -1454,7 +1475,12 @@ private function resolveType(string $exprString, Expr $node): Type
 						new FloatType(),
 					]);
 				}
-				return $stringType;
+
+				return new BenevolentUnionType([
+					$stringType,
+					new IntegerType(),
+					new FloatType(),
+				]);
 			}
 
 			if ($node instanceof Expr\PreInc) {

diff --git a/tests/PHPStan/Analyser/data/bug-10122.php b/tests/PHPStan/Analyser/data/bug-10122.php
@@ -34,7 +34,7 @@ function(float $f) {
 }
 
 /** @param numeric-string $ns */
-function doNumericString(string $ns) {
+function doNumericString(string $ns):void {
 	function() use ($ns) {
 		assertType('(float|int)', ++$ns);
 	};