CallStaticMethodsRule - do not report abstract method called on static::

phpstan · Jan 26, 2020 · 2639969 · 2639969
1 parent 1f272c3
commit 2639969
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Rules/Methods/CallStaticMethodsRule.php b/src/Rules/Methods/CallStaticMethodsRule.php
@@ -143,7 +143,7 @@ public function processNode(Node $node, Scope $scope): array
 			$className = $classReflection->getName();
 			$classType = new ObjectType($className);
 
-			if ($classReflection->hasNativeMethod($methodName)) {
+			if ($classReflection->hasNativeMethod($methodName) && $lowercasedClassName !== 'static') {
 				$nativeMethodReflection = $classReflection->getNativeMethod($methodName);
 				if ($nativeMethodReflection instanceof PhpMethodReflection || $nativeMethodReflection instanceof NativeMethodReflection) {
 					$isAbstract = $nativeMethodReflection->isAbstract();

diff --git a/tests/PHPStan/Rules/Methods/data/call-parent-abstract-method.php b/tests/PHPStan/Rules/Methods/data/call-parent-abstract-method.php
@@ -60,3 +60,15 @@ abstract static function doFoo(): void;
 function (): void {
 	SitAmet::doFoo();
 };
+
+abstract class Consecteur
+{
+
+	public function doFoo()
+	{
+		static::doBar();
+	}
+
+	abstract public function doBar(): void;
+
+}