Forbid PHPUnitPHAR prefixed classes

phpstan · Apr 5, 2024 · 2856081 · 2856081
1 parent 677afdd
commit 2856081
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/src/Rules/ClassForbiddenNameCheck.php b/src/Rules/ClassForbiddenNameCheck.php
@@ -19,6 +19,7 @@ class ClassForbiddenNameCheck
 		'PHPStan' => '_PHPStan_',
 		'Rector' => 'RectorPrefix',
 		'PHP-Scoper' => '_PhpScoper',
+		'PHPUnit' => 'PHPUnitPHAR',
 	];
 
 	public function __construct(private Container $container)

diff --git a/tests/PHPStan/Rules/Classes/ExistingClassInClassExtendsRuleTest.php b/tests/PHPStan/Rules/Classes/ExistingClassInClassExtendsRuleTest.php
@@ -108,14 +108,19 @@ public function testPhpstanInternalClass(): void
 			],
 			[
 				'Referencing prefixed Rector class: RectorPrefix202302\AClass.',
-				52,
+				56,
 				$tip,
 			],
 			[
 				'Referencing prefixed PHP-Scoper class: _PhpScoper19ae93be897e\AClass.',
-				55,
+				59,
 				$tip,
 			],
+			[
+				'Referencing prefixed PHPUnit class: PHPUnitPHAR\SebastianBergmann\Diff\Exception.',
+				62,
+				'This is most likely unintentional. Did you mean to type \SebastianBergmann\Diff\Exception?',
+			],
 		]);
 	}
 

diff --git a/tests/PHPStan/Rules/Classes/data/phpstan-internal-class.php b/tests/PHPStan/Rules/Classes/data/phpstan-internal-class.php
@@ -47,10 +47,18 @@ class AClass {
 	const Test = 1;
 }
 
+namespace PHPUnitPHAR\SebastianBergmann\Diff; // mimicks a prefixed class, as contained in PHPUnit phar
+
+class Exception{}
+
 namespace TestPhpstanInternalClass2;
 
 class FooBar extends \RectorPrefix202302\AClass
 {}
 
 class Baz extends \_PhpScoper19ae93be897e\AClass
 {}
+
+class BazBar extends \PHPUnitPHAR\SebastianBergmann\Diff\Exception
+{}
+