Enum-case comparison: cheap checks first

phpstan · May 10, 2024 · 3ad6515 · 3ad6515
1 parent 73521c3
commit 3ad6515
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/Type/Enum/EnumCaseObjectType.php b/src/Type/Enum/EnumCaseObjectType.php
@@ -53,8 +53,8 @@ public function equals(Type $type): bool
 			return false;
 		}
 
-		return $this->getClassName() === $type->getClassName()
-			&& $this->enumCaseName === $type->enumCaseName;
+		return $this->enumCaseName === $type->enumCaseName &&
+			$this->getClassName() === $type->getClassName();
 	}
 
 	public function accepts(Type $type, bool $strictTypes): TrinaryLogic
@@ -71,8 +71,7 @@ public function isSuperTypeOf(Type $type): TrinaryLogic
 	{
 		if ($type instanceof self) {
 			return TrinaryLogic::createFromBoolean(
-				$this->getClassName() === $type->getClassName()
-				&& $this->enumCaseName === $type->enumCaseName,
+				$this->enumCaseName === $type->enumCaseName && $this->getClassName() === $type->getClassName(),
 			);
 		}