Fixes

phpstan · Jan 8, 2023 · 4115456 · 4115456
1 parent 8baf6d1
commit 4115456
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 18 deletions.
diff --git a/src/Reflection/Annotations/AnnotationMethodReflection.php b/src/Reflection/Annotations/AnnotationMethodReflection.php
@@ -113,6 +113,14 @@ public function hasSideEffects(): TrinaryLogic
 			return TrinaryLogic::createYes();
 		}
 
+		foreach ($this->getVariants() as $variant) {
+			foreach ($variant->getParameters() as $parameter) {
+				if ($parameter->passedByReference()->yes()) {
+					return TrinaryLogic::createYes();
+				}
+			}
+		}
+
 		return TrinaryLogic::createMaybe();
 	}
 

diff --git a/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php b/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php
@@ -199,12 +199,10 @@ public function hasSideEffects(): TrinaryLogic
 		if ($this->isPure !== null) {
 			return TrinaryLogic::createFromBoolean(!$this->isPure);
 		}
-		if ($this->variants !== null) {
-			foreach ($this->variants as $variant) {
-				foreach ($variant->getParameters() as $parameter) {
-					if ($parameter->passedByReference()->yes()) {
-						return TrinaryLogic::createYes();
-					}
+		foreach ($this->getVariants() as $variant) {
+			foreach ($variant->getParameters() as $parameter) {
+				if ($parameter->passedByReference()->yes()) {
+					return TrinaryLogic::createYes();
 				}
 			}
 		}

diff --git a/src/Reflection/Php/PhpFunctionReflection.php b/src/Reflection/Php/PhpFunctionReflection.php
@@ -245,12 +245,10 @@ public function hasSideEffects(): TrinaryLogic
 		if ($this->isPure !== null) {
 			return TrinaryLogic::createFromBoolean(!$this->isPure);
 		}
-		if ($this->variants !== null) {
-			foreach ($this->variants as $variant) {
-				foreach ($variant->getParameters() as $parameter) {
-					if ($parameter->passedByReference()->yes()) {
-						return TrinaryLogic::createYes();
-					}
+		foreach ($this->getVariants() as $variant) {
+			foreach ($variant->getParameters() as $parameter) {
+				if ($parameter->passedByReference()->yes()) {
+					return TrinaryLogic::createYes();
 				}
 			}
 		}

diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -416,12 +416,10 @@ public function hasSideEffects(): TrinaryLogic
 		if ($this->isPure !== null) {
 			return TrinaryLogic::createFromBoolean(!$this->isPure);
 		}
-		if ($this->variants !== null) {
-			foreach ($this->variants as $variant) {
-				foreach ($variant->getParameters() as $parameter) {
-					if ($parameter->passedByReference()->yes()) {
-						return TrinaryLogic::createYes();
-					}
+		foreach ($this->getVariants() as $variant) {
+			foreach ($variant->getParameters() as $parameter) {
+				if ($parameter->passedByReference()->yes()) {
+					return TrinaryLogic::createYes();
 				}
 			}
 		}