Remove ImplodeFunctionRule changes

phpstan · Oct 8, 2021 · 441a3cf · 441a3cf
1 parent 10354ec
commit 441a3cf
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 54 deletions.
diff --git a/src/Rules/Functions/ImplodeFunctionRule.php b/src/Rules/Functions/ImplodeFunctionRule.php
@@ -10,7 +10,6 @@
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Type\ErrorType;
 use PHPStan\Type\Type;
-use PHPStan\Type\UnionType;
 use PHPStan\Type\VerbosityLevel;
 
 /**
@@ -68,8 +67,6 @@ static function (Type $type): bool {
 			}
 		);
 
-		$type = $typeResult->getType();
-
 		if ($typeResult->getType() instanceof ErrorType
 			|| !$typeResult->getType()->getIterableValueType()->toString() instanceof ErrorType) {
 			return [];
@@ -82,21 +79,4 @@ static function (Type $type): bool {
 		];
 	}
 
-	private function checkContainsErrorTypeAfterConversion(Type $type): bool
-	{
-		if ($type->getIterableValueType()->toString() instanceof ErrorType) {
-			return true;
-		}
-
-		if ($type instanceof UnionType) {
-			foreach ($type->getTypes() as $concreteType) {
-				if ($this->checkContainsErrorTypeAfterConversion($concreteType)) {
-					return true;
-				}
-			}
-		}
-
-		return false;
-	}
-
 }
diff --git a/tests/PHPStan/Rules/Functions/ImplodeFunctionRuleTest.php b/tests/PHPStan/Rules/Functions/ImplodeFunctionRuleTest.php
@@ -46,18 +46,4 @@ public function testFile(): void
 		]);
 	}
 
-	public function testRuleWithNullsafeVariant(): void
-	{
-		if (PHP_VERSION_ID < 80000) {
-			$this->markTestSkipped('Test requires PHP 8.0.');
-		}
-
-		$this->analyse([__DIR__ . '/data/implode-nullsafe.php'], [
-			[
-				'Parameter #1 $array of function implode expects array<string>, array<int, array<string>>|null given.',
-				17,
-			],
-		]);
-	}
-
 }
diff --git a/tests/PHPStan/Rules/Functions/data/implode-nullsafe.php b/tests/PHPStan/Rules/Functions/data/implode-nullsafe.php