Fix numeric-string negated intersection

phpstan · Aug 30, 2022 · 493284c · 493284c
1 parent 41be802
commit 493284c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/Type/Php/IsNumericFunctionTypeSpecifyingExtension.php b/src/Type/Php/IsNumericFunctionTypeSpecifyingExtension.php
@@ -41,14 +41,11 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n
 		$numericTypes = [
 			new IntegerType(),
 			new FloatType(),
-		];
-
-		if ($context->truthy()) {
-			$numericTypes[] = new IntersectionType([
+			new IntersectionType([
 				new StringType(),
 				new AccessoryNumericStringType(),
-			]);
-		}
+			]),
+		];
 
 		return $this->typeSpecifier->create($node->getArgs()[0]->value, new UnionType($numericTypes), $context, false, $scope);
 	}

diff --git a/tests/PHPStan/Analyser/TypeSpecifierTest.php b/tests/PHPStan/Analyser/TypeSpecifierTest.php
@@ -102,7 +102,7 @@ public function dataCondition(): array
 			[
 				$this->createFunctionCall('is_numeric'),
 				['$foo' => 'float|int|numeric-string'],
-				['$foo' => '~float|int'],
+				['$foo' => '~float|int|numeric-string'],
 			],
 			[
 				$this->createFunctionCall('is_scalar'),