Move explicit is_array mixed feature behind feature toggle

phpstan · Apr 12, 2022 · 56207bd · 56207bd
1 parent 2fba73d
commit 56207bd
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/conf/bleedingEdge.neon b/conf/bleedingEdge.neon
@@ -3,6 +3,7 @@ parameters:
 		bleedingEdge: true
 		skipCheckGenericClasses: []
 		explicitMixedInUnknownGenericNew: true
+		explicitMixedViaIsArray: true
 		arrayFilter: true
 	stubFiles:
 		- ../stubs/bleedingEdge/Countable.stub
diff --git a/conf/config.neon b/conf/config.neon
@@ -28,6 +28,7 @@ parameters:
 			- FilterIterator
 			- RecursiveCallbackFilterIterator
 		explicitMixedInUnknownGenericNew: false
+		explicitMixedViaIsArray: false
 		arrayFilter: false
 	fileExtensions:
 		- php
@@ -212,6 +213,7 @@ parametersSchema:
 		disableRuntimeReflectionProvider: bool(),
 		skipCheckGenericClasses: listOf(string()),
 		explicitMixedInUnknownGenericNew: bool(),
+		explicitMixedViaIsArray: bool(),
 		arrayFilter: bool(),
 	])
 	fileExtensions: listOf(string())
@@ -1424,6 +1426,8 @@ services:
 		class: PHPStan\Type\Php\IsArrayFunctionTypeSpecifyingExtension
 		tags:
 			- phpstan.typeSpecifier.functionTypeSpecifyingExtension
+		arguments:
+			explicitMixed: %featureToggles.explicitMixedViaIsArray%
 
 	-
 		class: PHPStan\Type\Php\IsBoolFunctionTypeSpecifyingExtension

diff --git a/src/Type/Php/IsArrayFunctionTypeSpecifyingExtension.php b/src/Type/Php/IsArrayFunctionTypeSpecifyingExtension.php
@@ -20,6 +20,11 @@ class IsArrayFunctionTypeSpecifyingExtension implements FunctionTypeSpecifyingEx
 
 	private TypeSpecifier $typeSpecifier;
 
+	public function __construct(private bool $explicitMixed)
+	{
+	}
+
+
 	public function isFunctionSupported(FunctionReflection $functionReflection, FuncCall $node, TypeSpecifierContext $context): bool
 	{
 		return strtolower($functionReflection->getName()) === 'is_array'
@@ -35,7 +40,7 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n
 			throw new ShouldNotHappenException();
 		}
 
-		return $this->typeSpecifier->create($node->getArgs()[0]->value, new ArrayType(new MixedType(true), new MixedType(true)), $context, false, $scope);
+		return $this->typeSpecifier->create($node->getArgs()[0]->value, new ArrayType(new MixedType($this->explicitMixed), new MixedType($this->explicitMixed)), $context, false, $scope);
 	}
 
 	public function setTypeSpecifier(TypeSpecifier $typeSpecifier): void