Transform sources with Rector

.github/workflows/compiler-tests.yml

@@ -29,10 +29,10 @@ jobs:
           php-version: "8.0"
 
       - name: "Install dependencies"
-        run: "composer install --no-dev --no-interaction --no-progress"
+        run: "composer install --no-interaction --no-progress"
 
       - name: "Transform source code"
-        run: php bin/transform-source.php
+        run: build/transform-source
 
       - name: "Tests"
         run: |

.github/workflows/lint.yml

@@ -44,9 +44,23 @@ jobs:
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
+      - name: "Install PHP for code transform"
+        if: matrix.php-version != '7.4' && matrix.php-version != '8.0' && matrix.php-version != '8.1'
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: 8.0
+
       - name: "Transform source code"
         if: matrix.php-version != '7.4' && matrix.php-version != '8.0' && matrix.php-version != '8.1'
-        run: php bin/transform-source.php
+        run: build/transform-source
+
+      - name: "Reinstall matrix PHP version"
+        if: matrix.php-version != '7.4' && matrix.php-version != '8.0' && matrix.php-version != '8.1'
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: "${{ matrix.php-version }}"
 
       - name: "Lint"
         run: "make lint"

.github/workflows/phar-old.yml

@@ -34,7 +34,7 @@ jobs:
         run: "composer install --no-interaction --no-progress --working-dir=compiler"
 
       - name: "Transform source code"
-        run: php bin/transform-source.php
+        run: build/transform-source
 
       - name: "Compile PHAR"
         run: php compiler/bin/compile

.github/workflows/phar.yml

@@ -36,7 +36,7 @@ jobs:
         run: "composer install --no-interaction --no-progress --working-dir=compiler"
 
       - name: "Transform source code"
-        run: php bin/transform-source.php
+        run: build/transform-source
 
       - name: "Compile PHAR"
         run: php compiler/bin/compile

.github/workflows/static-analysis.yml

@@ -47,9 +47,26 @@ jobs:
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
+      - name: "Install PHP for code transform"
+        if: matrix.php-version != '7.4' && matrix.php-version != '8.0' && matrix.php-version != '8.1'
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: 8.0
+          extensions: mbstring
+
       - name: "Transform source code"
         if: matrix.php-version != '7.4' && matrix.php-version != '8.0' && matrix.php-version != '8.1'
-        run: php bin/transform-source.php
+        shell: bash
+        run: build/transform-source
+
+      - name: "Reinstall matrix PHP version"
+        if: matrix.php-version != '7.4' && matrix.php-version != '8.0' && matrix.php-version != '8.1'
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: "${{ matrix.php-version }}"
+          extensions: mbstring
 
       - name: "Downgrade PHPUnit"
         if: matrix.php-version == '7.1' || matrix.php-version == '7.2'

.github/workflows/tests.yml

@@ -47,9 +47,28 @@ jobs:
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
+      - name: "Install PHP for code transform"
+        if: matrix.php-version != '7.4' && matrix.php-version != '8.0' && matrix.php-version != '8.1'
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: 8.0
+          extensions: mbstring
+
       - name: "Transform source code"
         if: matrix.php-version != '7.4' && matrix.php-version != '8.0' && matrix.php-version != '8.1'
-        run: php bin/transform-source.php
+        shell: bash
+        run: build/transform-source
+
+      - name: "Reinstall matrix PHP version"
+        if: matrix.php-version != '7.4' && matrix.php-version != '8.0' && matrix.php-version != '8.1'
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: "${{ matrix.php-version }}"
+          tools: pecl
+          extensions: ds,mbstring
+          ini-values: memory_limit=640M
 
       - name: "Tests"
         run: "${{ matrix.script }}"
@@ -87,8 +106,24 @@ jobs:
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
+      - name: "Install PHP for code transform"
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: "8.0"
+
       - name: "Transform source code"
-        run: php bin/transform-source.php
+        shell: bash
+        run: build/transform-source
+
+      - name: "Reinstall matrix PHP version"
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: "${{ matrix.php-version }}"
+          tools: pecl
+          extensions: ds,mbstring
+          ini-values: memory_limit=640M
 
       - name: "Downgrade PHPUnit"
         run: "composer require --dev phpunit/phpunit:^7.5.20 brianium/paratest:^4.0 --update-with-dependencies"

build/rector-downgrade.php

@@ -0,0 +1,18 @@
+<?php declare(strict_types=1);
+
+use Rector\Core\Configuration\Option;
+use Rector\DowngradePhp74\Rector\Property\DowngradeTypedPropertyRector;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+	$parameters = $containerConfigurator->parameters();
+
+	$parameters->set(Option::SKIP, [
+		'tests/*/data/*',
+		'tests/PHPStan/Analyser/traits/*',
+		'tests/PHPStan/Generics/functions.php',
+	]);
+
+	$services = $containerConfigurator->services();
+	$services->set(DowngradeTypedPropertyRector::class);
+};

build/transform-source

@@ -0,0 +1,7 @@
+#!/usr/bin/env bash
+
+set -o errexit
+set -o pipefail
+set -o nounset
+
+vendor/bin/rector process src tests/PHPStan -c build/rector-downgrade.php

compiler/src/Console/CompileCommand.php

@@ -260,7 +260,8 @@ private function patchFile(OutputInterface $output, string $originalFile, string
 
 	private function transformSource(): void
 	{
-		exec(escapeshellarg(__DIR__ . '/../../../bin/transform-source.php'), $outputLines, $exitCode);
+		chdir(__DIR__ . '/../../..');
+		exec(escapeshellarg(__DIR__ . '/../../../build/transform-source'), $outputLines, $exitCode);
 		if ($exitCode === 0) {
 			return;
 		}

composer.json

@@ -48,6 +48,7 @@
 		"phpstan/phpstan-phpunit": "^1.0",
 		"phpstan/phpstan-strict-rules": "^1.0",
 		"phpunit/phpunit": "^9.5.4",
+		"rector/rector": "0.12.5",
 		"vaimo/composer-patches": "^4.22"
 	},
 	"config": {

patches/NameNodeMapper.patch

@@ -0,0 +1,13 @@
+@package rector/rector
+
+--- packages/StaticTypeMapper/PhpParser/NameNodeMapper.php	2021-11-23 18:38:29.000000000 +0100
++++ packages/StaticTypeMapper/PhpParser/NameNodeMapper2.php	2021-12-16 23:09:30.000000000 +0100
+@@ -106,7 +106,7 @@
+             }
+             return new \Rector\StaticTypeMapper\ValueObject\Type\ParentObjectWithoutClassType();
+         }
+-        return new \PHPStan\Type\ThisType($classReflection);
++        return new \PHPStan\Type\ObjectType($classReflection->getName());
+     }
+     /**
+      * @return \PHPStan\Type\ArrayType|\PHPStan\Type\BooleanType|\PHPStan\Type\Constant\ConstantBooleanType|\PHPStan\Type\FloatType|\PHPStan\Type\IntegerType|\PHPStan\Type\MixedType|\PHPStan\Type\StringType