test: add test for subtracted mixed

phpstan · May 11, 2024 · a23a9f8 · a23a9f8
1 parent 321432a
commit a23a9f8
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 2 deletions.
diff --git a/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php b/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php
@@ -772,13 +772,37 @@ public function testMixed(): void
 				'Cannot access offset 5 on T of mixed.',
 				11,
 			],
+			[
+				'Cannot access offset 5 on T of mixed.',
+				12,
+			],
+			[
+				'Cannot access offset 5 on T of mixed.',
+				18,
+			],
 			[
 				'Cannot access offset 5 on mixed.',
-				16,
+				24,
+			],
+			[
+				'Cannot access offset 5 on mixed.',
+				25,
+			],
+			[
+				'Cannot access offset 5 on mixed.',
+				31,
+			],
+			[
+				'Cannot access offset 5 on mixed.',
+				37,
+			],
+			[
+				'Cannot access offset 5 on mixed.',
+				38,
 			],
 			[
 				'Cannot access offset 5 on mixed.',
-				21,
+				44,
 			],
 		]);
 	}

diff --git a/tests/PHPStan/Rules/Arrays/data/offset-access-mixed.php b/tests/PHPStan/Rules/Arrays/data/offset-access-mixed.php
@@ -9,14 +9,38 @@
 function foo(mixed $a): void
 {
 	var_dump($a[5]);
+	isset($a[5]); // error, because including object type
+
+	if (is_object($a)) {
+		throw new \Error();
+	}
+
+	var_dump($a[5]); // error
+	isset($a[5]); // ok, because object type, which throws an error do not implement ArrayAccess, is subtracted
 }
 
 function foo2(mixed $a): void
 {
 	var_dump($a[5]);
+	isset($a[5]);
+
+	if (is_object($a)) {
+		throw new \Error();
+	}
+
+	var_dump($a[5]); // error
+	isset($a[5]); // ok, because object type, which throws an error do not implement ArrayAccess, is subtracted
 }
 
 function foo3($a): void
 {
 	var_dump($a[5]);
+	isset($a[5]);
+
+	if (is_object($a)) {
+		throw new \Error();
+	}
+
+	var_dump($a[5]); // error
+	isset($a[5]); // ok, because object type, which throws an error do not implement ArrayAccess, is subtracted
 }