Access to an undefined property should be appropriate for these cases.

Should be fixed by specifying types in isset. Related issue phpstan/phpstan#3171
phpstan · Apr 21, 2022 · a624060 · a624060
1 parent e64bc9a
commit a624060
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Rules/Properties/AccessPropertiesRule.php b/src/Rules/Properties/AccessPropertiesRule.php
@@ -79,7 +79,7 @@ private function processSingleProperty(Scope $scope, PropertyFetch $node, string
 			return [];
 		}
 
-		if ($type->canAccessProperties()->no() || $type->canAccessProperties()->maybe() && !$this->canAccessUndefinedProperties($scope, $node)) {
+		if ($type->canAccessProperties()->no() || $type->canAccessProperties()->maybe() && !$scope->isUndefinedExpressionAllowed($node)) {
 			return [
 				RuleErrorBuilder::message(sprintf(
 					'Cannot access property $%s on %s.',

diff --git a/tests/PHPStan/Rules/Properties/AccessPropertiesRuleTest.php b/tests/PHPStan/Rules/Properties/AccessPropertiesRuleTest.php
@@ -495,7 +495,7 @@ public function testAccessPropertiesOnDynamicProperties(): void
 					299,
 				],
 				[
-					'Cannot access property $foo on TestAccessProperties\PropertyIssetOnPossibleFalse|false.',
+					'Access to an undefined property TestAccessProperties\PropertyIssetOnPossibleFalse|false::$foo.',
 					315,
 				],
 				[
@@ -511,7 +511,7 @@ public function testAccessPropertiesOnDynamicProperties(): void
 					402,
 				],
 				[
-					'Cannot access property $array on stdClass|null.',
+					'Access to an undefined property stdClass|null::$array.',
 					412,
 				],
 			],