Add config option to exclude mixin classes

phpstan · May 7, 2020 · b5a6597 · clxmstaab · May 7, 2020 · ondrejmirtes
1 parent b58d311
commit b5a6597
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 0 deletions.
diff --git a/conf/config.neon b/conf/config.neon
@@ -39,6 +39,7 @@ parameters:
 	reportMaybes: false
 	reportMaybesInMethodSignatures: false
 	reportStaticMethodSignatures: false
+	mixinExcludeClasses: []
 	parallel:
 		jobSize: 20
 		processTimeout: 60.0
@@ -215,6 +216,7 @@ parametersSchema:
 	tmpDir: string()
 	currentWorkingDirectory: string()
 	cliArgumentsVariablesRegistered: bool()
+	mixinExcludeClasses: listOf(string())
 
 	# irrelevant Nette parameters
 	debugMode: bool()
@@ -480,11 +482,15 @@ services:
 		class: PHPStan\Reflection\Mixin\MixinMethodsClassReflectionExtension
 		tags:
 			- phpstan.broker.methodsClassReflectionExtension
+		arguments:
+			mixinExcludeClasses: %mixinExcludeClasses%
 
 	-
 		class: PHPStan\Reflection\Mixin\MixinPropertiesClassReflectionExtension
 		tags:
 			- phpstan.broker.propertiesClassReflectionExtension
+		arguments:
+			mixinExcludeClasses: %mixinExcludeClasses%
 
 	-
 		class: PHPStan\Reflection\Php\PhpClassReflectionExtension

diff --git a/src/Reflection/Mixin/MixinMethodsClassReflectionExtension.php b/src/Reflection/Mixin/MixinMethodsClassReflectionExtension.php
@@ -6,10 +6,22 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\MethodsClassReflectionExtension;
+use PHPStan\Type\TypeUtils;
 
 class MixinMethodsClassReflectionExtension implements MethodsClassReflectionExtension
 {
 
+	/** @var string[] */
+	private $mixinExcludeClasses;
+
+	/**
+	 * @param string[] $mixinExcludeClasses
+	 */
+	public function __construct(array $mixinExcludeClasses)
+	{
+		$this->mixinExcludeClasses = $mixinExcludeClasses;
+	}
+
 	public function hasMethod(ClassReflection $classReflection, string $methodName): bool
 	{
 		return $this->findMethod($classReflection, $methodName) !== null;
@@ -29,6 +41,10 @@ private function findMethod(ClassReflection $classReflection, string $methodName
 	{
 		$mixinTypes = $classReflection->getResolvedMixinTypes();
 		foreach ($mixinTypes as $type) {
+			if (count(array_intersect(TypeUtils::getDirectClassNames($type), $this->mixinExcludeClasses)) > 0) {
+				continue;
+			}
+
 			if (!$type->hasMethod($methodName)->yes()) {
 				continue;
 			}

diff --git a/src/Reflection/Mixin/MixinPropertiesClassReflectionExtension.php b/src/Reflection/Mixin/MixinPropertiesClassReflectionExtension.php
@@ -6,10 +6,22 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\PropertiesClassReflectionExtension;
 use PHPStan\Reflection\PropertyReflection;
+use PHPStan\Type\TypeUtils;
 
 class MixinPropertiesClassReflectionExtension implements PropertiesClassReflectionExtension
 {
 
+	/** @var string[] */
+	private $mixinExcludeClasses;
+
+	/**
+	 * @param string[] $mixinExcludeClasses
+	 */
+	public function __construct(array $mixinExcludeClasses)
+	{
+		$this->mixinExcludeClasses = $mixinExcludeClasses;
+	}
+
 	public function hasProperty(ClassReflection $classReflection, string $propertyName): bool
 	{
 		return $this->findProperty($classReflection, $propertyName) !== null;
@@ -29,6 +41,10 @@ private function findProperty(ClassReflection $classReflection, string $property
 	{
 		$mixinTypes = $classReflection->getResolvedMixinTypes();
 		foreach ($mixinTypes as $type) {
+			if (count(array_intersect(TypeUtils::getDirectClassNames($type), $this->mixinExcludeClasses)) > 0) {
+				continue;
+			}
+
 			if (!$type->hasProperty($propertyName)->yes()) {
 				continue;
 			}