BetterNoopRule - detect FuncCall with Expr

phpstan · Apr 18, 2024 · b9d990b · b9d990b
1 parent 57b0ae0
commit b9d990b
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/src/Rules/DeadCode/BetterNoopRule.php b/src/Rules/DeadCode/BetterNoopRule.php
@@ -80,7 +80,7 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		if (
-			$expr instanceof Node\Expr\FuncCall
+			($expr instanceof Node\Expr\FuncCall && $expr->name instanceof Node\Name)
 			|| $expr instanceof Node\Expr\NullsafeMethodCall
 			|| $expr instanceof Node\Expr\MethodCall
 			|| $expr instanceof Node\Expr\New_

diff --git a/tests/PHPStan/Rules/DeadCode/BetterNoopRuleTest.php b/tests/PHPStan/Rules/DeadCode/BetterNoopRuleTest.php
@@ -128,6 +128,10 @@ public function testRuleImpurePoints(): void
 				'Unused result of "&&" operator.',
 				10,
 			],
+			[
+				'Expression "$b()" on a separate line does not do anything.',
+				57,
+			],
 		]);
 	}
 

diff --git a/tests/PHPStan/Rules/DeadCode/data/noop-impure-points.php b/tests/PHPStan/Rules/DeadCode/data/noop-impure-points.php
@@ -44,4 +44,17 @@ public function doAssign(bool $b): void
 		$b ? $this->foo = 1 : '';
 	}
 
+	public function doClosures(): void
+	{
+		$a = static function () {
+			echo '1';
+		};
+		$a();
+
+		$b = static function () {
+			return 1 + 1;
+		};
+		$b();
+	}
+
 }