Support float -> int and bool|float|int|null -> string cast v…

…ia `filter_var()`
phpstan · Dec 27, 2022 · c17b58e · c17b58e
1 parent 63adbba
commit c17b58e
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/src/Type/Php/FilterVarDynamicReturnTypeExtension.php b/src/Type/Php/FilterVarDynamicReturnTypeExtension.php
@@ -231,6 +231,14 @@ private function determineExactType(Type $in, int $filterValue, Type $defaultTyp
 			return $in->toFloat();
 		}
 
+		if ($filterValue === $this->getConstant('FILTER_VALIDATE_INT') && $in->isFloat()->yes()) {
+			return $in->toInteger();
+		}
+
+		if ($filterValue === $this->getConstant('FILTER_DEFAULT') && ($in->isBoolean()->yes() || $in->isFloat()->yes() || $in->isInteger()->yes() || $in->isNull()->yes())) {
+			return $in->toString();
+		}
+
 		return null;
 	}
 

diff --git a/tests/PHPStan/Analyser/data/filter-var-returns-non-empty-string.php b/tests/PHPStan/Analyser/data/filter-var-returns-non-empty-string.php
@@ -82,7 +82,10 @@ public function run(string $str, int $int, int $positive_int, int $negative_int)
 		assertType('9', $return);
 
 		$return = filter_var(1.0, FILTER_VALIDATE_INT, ['options' => ['min_range' => 1, 'max_range' => 9]]);
-		assertType('int<1, 9>|false', $return);
+		assertType('1', $return);
+
+		$return = filter_var(11.0, FILTER_VALIDATE_INT, ['options' => ['min_range' => 1, 'max_range' => 9]]);
+		assertType('false', $return);
 
 		$return = filter_var($str, FILTER_VALIDATE_INT, ['options' => ['min_range' => 1, 'max_range' => $positive_int]]);
 		assertType('int<1, max>|false', $return);

diff --git a/tests/PHPStan/Analyser/data/filter-var.php b/tests/PHPStan/Analyser/data/filter-var.php
@@ -26,7 +26,16 @@ public function intToInt(int $int, array $options): void
 	public function constants(): void
 	{
 		assertType('array<false>', filter_var(false, FILTER_VALIDATE_BOOLEAN, FILTER_FORCE_ARRAY | FILTER_NULL_ON_FAILURE));
+
 		assertType('17', filter_var(17, FILTER_VALIDATE_INT));
+
+		assertType('17.0', filter_var(17, FILTER_VALIDATE_FLOAT));
+
+		assertType("'17'", filter_var(17));
+		assertType("'17'", filter_var(17.0));
+		assertType("'1'", filter_var(true));
+		assertType("''", filter_var(false));
+		assertType("''", filter_var(null));
 	}
 
 }