Notes on questions for next steps

phpstan · Nov 18, 2021 · c815c71 · c815c71
1 parent 1c3c5e3
commit c815c71
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 5 deletions.
diff --git a/src/Type/Constant/ConstantArrayType.php b/src/Type/Constant/ConstantArrayType.php
@@ -315,6 +315,12 @@ public function equals(Type $type): bool
 
 	public function isCallable(): TrinaryLogic
 	{
+		// @todo is there a way to fetch the full scope here.
+		// An OutOfClassScope causes frivolous errors when checking if a
+		// non-static method was invoked statically in its own class, which
+		// is allowed per: https://3v4l.org/mTa9S.
+		// Should add an optional scope parameter to isCallable and if null,
+		// create a new OutOfClassScope instance.
 		$typeAndMethod = $this->findTypeAndMethodName(new OutOfClassScope());
 		if ($typeAndMethod === null) {
 			return TrinaryLogic::createNo();

diff --git a/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php b/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php
@@ -451,11 +451,18 @@ public function testBug5782(): void
 		$this->analyse([__DIR__ . '/data/bug-5782.php'], [
 			[
 				'Parameter #1 $callback of static method Closure::fromCallable() expects callable(): mixed, array{\'Bug5782\\\HelloWorld\', \'sayGoodbye\'} given.',
-				22,
+				23,
 			],
 			[
 				'Parameter #1 $callback of static method Closure::fromCallable() expects callable(): mixed, array{\'Bug5782\\\HelloWorld\', \'sayGoodbye\'} given.',
-				26,
+				30,
+			],
+			// @todo this should also error on mixed type, but doesn't?
+			// ConstantStringType::getCallableParametersAcceptors returns a
+			// MixedType but that doesn't cause an error like ConstantArrayType.
+			[
+				'Parameter #1 $callback of static method Closure::fromCallable() expects callable(): mixed, array{\'Bug5782\\\HelloWorld\', \'sayGoodbye\'} given.',
+				31,
 			],
 		]);
 	}

diff --git a/tests/PHPStan/Rules/Methods/data/bug-5782.php b/tests/PHPStan/Rules/Methods/data/bug-5782.php
@@ -16,12 +16,17 @@ public function sayGoodbye(): void
 
 }
 
+class FooWorld
+{
+	public function bazBar(): void
+	{
+		$closure1 = \Closure::fromCallable([\Bug5782\HelloWorld::class, 'sayGoodbye']);
+	}
+}
+
 function baz() {
 	$closure1 = \Closure::fromCallable([\Bug5782\HelloWorld::class, 'sayHello']);
 	$closure2 = \Closure::fromCallable('\Bug5782\HelloWorld::sayHello');
 	$closure3 = \Closure::fromCallable([\Bug5782\HelloWorld::class, 'sayGoodbye']);
-	// @todo this should also error on mixed type, but doesn't?
-	// ConstantStringType::getCallableParametersAcceptors returns a MixedType
-	// but that doesn't cause an error like ConstantArrayType.
 	$closure4 = \Closure::fromCallable('Bug5782\HelloWorld::sayGoodbye');
 }