Smoother parallel process quitting when the child process crashes

phpstan · Jan 13, 2021 · cbbbd36 · cbbbd36
1 parent 3c56362
commit cbbbd36
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Parallel/ParallelAnalyser.php b/src/Parallel/ParallelAnalyser.php
@@ -76,7 +76,7 @@ public function analyse(
 				$process = $this->processPool->getProcess($identifier);
 				$process->bindConnection($decoder, $encoder);
 				if (count($jobs) === 0) {
-					$this->processPool->quitProcess($identifier);
+					$this->processPool->tryQuitProcess($identifier);
 					return;
 				}
 
@@ -174,7 +174,7 @@ public function analyse(
 				}
 
 				if (count($jobs) === 0) {
-					$this->processPool->quitProcess($processIdentifier);
+					$this->processPool->tryQuitProcess($processIdentifier);
 					return;
 				}
 

diff --git a/src/Parallel/ProcessPool.php b/src/Parallel/ProcessPool.php
@@ -41,7 +41,7 @@ public function tryQuitProcess(string $identifier): void
 		$this->quitProcess($identifier);
 	}
 
-	public function quitProcess(string $identifier): void
+	private function quitProcess(string $identifier): void
 	{
 		$process = $this->getProcess($identifier);
 		$process->quit();